lh-profile-page.php began as a single "god class" (LH_profile_page_plugin) holding every field's rendering, validation, and storage logic. Starting with the phone field (v2.03) and continuing through v2.11, each field was extracted into its own dedicated class, following a consistent pattern:
For each field:
includes/lh-profile-{field}-field-class.php file holds the real, self-contained rendering/validation/storage methods as a static class (LH_Profile_{Field}_Field).LH_profile_page_plugin for every extracted public method, delegating to the new class. This exists because the original 2.03 phone extraction assumed no external plugin called these methods directly – that assumption was wrong (ppt-lh-membership-extender called render_phone_input() directly) and fatalled the site the moment 2.03 shipped. Every subsequent extraction leaves a shim regardless of whether an external caller is known, on the same "don't assume, leave the shim" principle.register_meta() registration, where the field has a real validation rule worth enforcing (see Database Schema doc for which fields this applies to).Since the gender/birthdate/address/name extractions (v2.09+), every shim proxy calls a shared maybe_log_external_shim_call() helper as its first line. This inspects the immediate caller's file via debug_backtrace(): calls originating from within lh-profile-page.php itself (expected, pre-extraction internal usage) are silently ignored; calls from any other file are logged at warning level via the plugin's write_log() convention, naming the exact method, file, and line.
This exists to turn "we assume nothing external calls this" into "we know nothing external calls this" – the only way to eventually make shim removal an evidence-based decision rather than a guess. Search LH Debug Log Viewer for "Deprecated shim" to find any external callers the logging has caught. One confirmed find this way: ppt-lh-membership-extender.php was calling render_phone_input(), render_gender_input(), and handle_phone_update() directly – all three were repointed to call LH_Profile_Phone_Field/LH_Profile_Gender_Field directly (site plugin, updated to v1.01).
| Field | Class | File |
|---|---|---|
| Phone (+ secondary) | LH_Profile_Phone_Field | lh-profile-phone-field-class.php |
| Gender | LH_Profile_Gender_Field | lh-profile-gender-field-class.php |
| Birthdate | LH_Profile_Birthdate_Field | lh-profile-birthdate-field-class.php |
| Street address | LH_Profile_Street_Address_Field | lh-profile-street-address-field-class.php |
| Town | LH_Profile_Town_Field | lh-profile-town-field-class.php |
| Postcode | LH_Profile_Postcode_Field | lh-profile-postcode-field-class.php |
| State/province | LH_Profile_State_Province_Field | lh-profile-state-province-field-class.php |
| Country | LH_Profile_Country_Field | lh-profile-country-field-class.php |
| First name | LH_Profile_First_Name_Field | lh-profile-first-name-field-class.php |
| Last name | LH_Profile_Last_Name_Field | lh-profile-last-name-field-class.php |
| Display name | LH_Profile_Display_Name_Field | lh-profile-display-name-field-class.php |
Address fields are five separate classes (not one shared class) deliberately – matching the one-class-per-field precedent, and because postcode specifically has real per-country format validation worth adding later (a self-contained future change if it stays in its own file).
The multi-field orchestrator methods – post_handler(), maybe_do_user_update(), new_user_update(), save_backend_profile_profile_fields(), maybe_add_details_when_csv_is_uploaded() – remain in the god class. Each reimplements "for each field: check nonce, check if already set, write if empty" for a different trigger context (frontend POST, backend admin save, CRM enquiry, group invite, CSV import). They're close to duplicates of each other and are the single biggest remaining opportunity to shrink the god class, but consolidating them is a real behaviour-preserving refactor across many call sites, not a quick extraction – flagged as future work, not attempted.
Emails (lh_profile-emails) was also deliberately left unextracted – it's slated for removal, its functionality being superseded by lh-user-identity.
Name field label methods (render_firstname_label(), render_lastname_label(), render_display_name_label()) were extracted then removed entirely (v2.12) once confirmed to have no caller anywhere, live or dead, beyond commented-out code.